Immediate UI feedback for shopify app execute and shopify app bulk execute#6793
Merged
ericlee878 merged 1 commit intomainfrom Jan 29, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ericlee878
changed the title
shopify app execute and shopify app bulk execute
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3689 tests passing in 1431 suites. Report generated by 🧪jest coverage report action from b867383 |
This comment has been minimized.
This comment has been minimized.
ericlee878
force-pushed
the
more-responsive-ui-for-beginning-of-cli
branch
from
4876c88 to
f689efe
Compare
ericlee878
force-pushed
the
more-responsive-ui-for-beginning-of-cli
branch
4 times, most recently
from
adbc1ae to
103a462
Compare
jordanverasamy
approved these changes
Jan 27, 2026
Contributor
jordanverasamy
left a comment
jordanverasamy
left a comment
There was a problem hiding this comment.
🎩 ! Looks good and works nicely, just needs one tiny polish cleanup :)
ericlee878
force-pushed
the
more-responsive-ui-for-beginning-of-cli
branch
from
103a462 to
b867383
Compare
Contributor
|
/snapit |
Contributor
|
🫰✨ Thanks @nickwesselman! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260129185510Caution After installing, validate the version by running just |
nickwesselman
approved these changes
Jan 29, 2026
Contributor
nickwesselman
left a comment
nickwesselman
left a comment
There was a problem hiding this comment.
Good from a DX POV
ryancbahan
approved these changes
Jan 29, 2026
Contributor
ryancbahan
left a comment
ryancbahan
left a comment
There was a problem hiding this comment.
I mentioned here that I think we really need a systemic solution for this, but given we don't have one now this makes sense to me.
ryancbahan
reviewed
Jan 29, 2026
| const version = await resolveApiVersion({adminSession, userSpecifiedVersion}) | ||
| return {adminSession, version} | ||
| }, | ||
| renderOptions: {stdout: process.stderr}, |
Contributor
There was a problem hiding this comment.
This pattern seems smelly to me. I'm unclear why it's necessary to pass the process around since it's a global. I see it's being done in a few other places for bulk commands, so I won't block, but I question whether this is the right approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by: https://docs.google.com/document/d/1zZVFeZn2jWbPI8pS9XvMMcXvNwXHKnEQoSGYeBMHyGk/edit?tab=t.0
Resolves: https://github.com/orgs/shop/projects/208/views/34?pane=issue&itemId=3840287153&issue=shop%7Cissues-api-foundations%7C1311
Problem
Users experience a noticeable delay (~1-3 seconds) between hitting enter and seeing any output. During this time, the CLI is performing necessary async operations (authentication, API version resolution) but provides no visual feedback, making the tool feel unresponsive.
Solution
Add a
renderSingleTaskcall at the very start of each command method, with the authentication and version lookup being the task it tracks. The message it shows isAuthenticating...There is still some lag at the beginning. Eliminating this lag entirely would require adding feedback to all Shopify CLI commands at the framework level, which is out of scope for this change.
Tophatting
Before:
Screen Recording 2026-01-22 at 5.41.18 PM.mov (uploaded via Graphite)
After:
Screen Recording 2026-01-28 at 12.57.18 PM.mov (uploaded via Graphite)
NOTE: IMPLEMENTATION HAS CHANGED UPON REVIEW
Check here for more details